Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect variable name #37

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update incorrect variable name #37

merged 1 commit into from
Sep 19, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Sep 19, 2024 •
edited
Loading

#38

Scope

Implemented:

  • Use backward-compatible secret layout in the StreamRunner

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner September 19, 2024 14:03
@github-actions GitHub Actions
Copy link

Coverage after merging update-incorrrect-variable-name into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–34, 34, 34–44, 47–49, 51
src/Models
   SqlServerChangeTrackingStreamContext.cs0%100%0%0%13, 18, 23, 28, 35, 40, 45, 50, 55, 61, 64, 67, 70, 74–76, 80–82, 86–88, 91–93, 96
src/Services
   SqlServerChangeTrackgingGraphBuilder.cs0%0%0%0%22–26, 29–30, 32, 34–42, 44–45, 47, 47, 47–54, 56–66, 68–70, 70, 70, 70, 70, 70, 70, 70, 70–73, 76, 76, 76, 76, 76, 76, 76, 76, 76–78, 81, 81, 81–85, 88–89, 91

@s-vitaliy s-vitaliy merged commit f153d35 into main Sep 19, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the update-incorrrect-variable-name branch September 19, 2024 14:42
@s-vitaliy s-vitaliy mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre-Lx-Costa Andre-Lx-Costa Andre-Lx-Costa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-vitaliy @Andre-Lx-Costa